Commit 68e12e5f authored Jun 15, 2020 by Jing Xiangfeng Committed by Martin K. Petersen Jul 28, 2020

scsi: iscsi: Do not put host in iscsi_set_flashnode_param()

If scsi_host_lookup() fails we will jump to put_host which may cause a
panic. Jump to exit_set_fnode instead.

Link: https://lore.kernel.org/r/20200615081226.183068-1-jingxiangfeng@huawei.com


Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 5759ff11

drivers/scsi/scsi_transport_iscsi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3290,7 +3290,7 @@ static int iscsi_set_flashnode_param(struct iscsi_transport *transport,
		pr_err("%s could not find host no %u\n",
		__func__, ev->u.set_flashnode.host_no);
		err = -ENODEV;
		goto put_host;
		goto exit_set_fnode;
		}

		idx = ev->u.set_flashnode.flashnode_idx;

Admin message