Commit 68c94e55 authored Feb 12, 2019 by Nikolay Borisov Committed by David Sterba Apr 29, 2019

btrfs: Transpose btrfs_close_devices/btrfs_mapping_tree_free in close_ctree

Following the introduction of the alloc_state tree, some of the callees
of btrfs_mapping_tree_free will have to interact with the btrfs_device
of the constituent devices. Enable this by moving the code responsible
for freeing devices after the last user (btrfs_mapping_tree_free).
Otherwise the kernel could crash due to use-after-free.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 8e75fd89

fs/btrfs/disk-io.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4040,8 +4040,8 @@ void close_ctree(struct btrfs_fs_info *fs_info)
		btrfsic_unmount(fs_info->fs_devices);
		#endif

		btrfs_close_devices(fs_info->fs_devices);
		btrfs_mapping_tree_free(&fs_info->mapping_tree);
		btrfs_close_devices(fs_info->fs_devices);

		percpu_counter_destroy(&fs_info->dirty_metadata_bytes);
		percpu_counter_destroy(&fs_info->delalloc_bytes);

Admin message