Commit 68c57bfd authored Dec 23, 2019 by Alexandra Winter Committed by David S. Miller Dec 24, 2019

s390/qeth: fix false reporting of VNIC CHAR config failure



Symptom: Error message "Configuring the VNIC characteristics failed"
in dmesg whenever an OSA interface on z15 is set online.

The VNIC characteristics get re-programmed when setting a L2 device
online. This follows the selected 'wanted' characteristics - with the
exception that the INVISIBLE characteristic unconditionally gets
switched off.

For devices that don't support INVISIBLE (ie. OSA), the resulting
IO failure raises a noisy error message
("Configuring the VNIC characteristics failed").
For IQD, INVISIBLE is off by default anyways.

So don't unnecessarily special-case the INVISIBLE characteristic, and
thereby suppress the misleading error message on OSA devices.

Fixes: caa1f0b1 ("s390/qeth: add VNICC enable/disable support")
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Reviewed-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5b6c7b55

drivers/s390/net/qeth_l2_main.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -2041,7 +2041,6 @@ static void qeth_l2_vnicc_init(struct qeth_card *card)
		error \|= qeth_l2_vnicc_recover_timeout(card, QETH_VNICC_LEARNING,
		timeout);
		chars_tmp = card->options.vnicc.wanted_chars ^ QETH_VNICC_DEFAULT;
		chars_tmp \|= QETH_VNICC_BRIDGE_INVISIBLE;
		chars_len = sizeof(card->options.vnicc.wanted_chars) * BITS_PER_BYTE;
		for_each_set_bit(i, &chars_tmp, chars_len) {
		vnicc = BIT(i);

Admin message