Commit 6888ff66 authored by Kan Liang's avatar Kan Liang Committed by Arnaldo Carvalho de Melo
Browse files

perf evlist: Remove stale mmap read for backward 



perf_evlist__mmap_read_catchup() and perf_evlist__mmap_read_backward()
are only for overwrite mode.

But they read the evlist->mmap buffer which is for non-overwrite mode.

It did not bring any serious problem yet, because there is no one use
it.

Remove the unused interfaces.

Signed-off-by: default avatarKan Liang <kan.liang@intel.com>
Acked-by: default avatarJiri Olsa <jolsa@kernel.org>
Acked-by: default avatarWang Nan <wangnan0@huawei.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jin Yao <yao.jin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1516310792-208685-2-git-send-email-kan.liang@intel.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 0b7c1528

tools/perf/util/evlist.c

+0 −17
Original line number Diff line number Diff line
@@ -715,28 +715,11 @@ union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist, int 
	return perf_mmap__read_forward(md);

}



union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist, int idx)

{

	struct perf_mmap *md = &evlist->mmap[idx];



	/*

	 * No need to check messup for backward ring buffer:

	 * We can always read arbitrary long data from a backward

	 * ring buffer unless we forget to pause it before reading.

	 */

	return perf_mmap__read_backward(md);

}



union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx)

{

	return perf_evlist__mmap_read_forward(evlist, idx);

}



void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx)

{

	perf_mmap__read_catchup(&evlist->mmap[idx]);

}



void perf_evlist__mmap_consume(struct perf_evlist *evlist, int idx)

{

	perf_mmap__consume(&evlist->mmap[idx], false);

tools/perf/util/evlist.h

+0 −4
Original line number Diff line number Diff line
@@ -133,10 +133,6 @@ union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx); 


union perf_event *perf_evlist__mmap_read_forward(struct perf_evlist *evlist,

						 int idx);

union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist,

						  int idx);

void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx);



void perf_evlist__mmap_consume(struct perf_evlist *evlist, int idx);



int perf_evlist__open(struct perf_evlist *evlist);

CRA Git | Maintained and supported by SUSTech CRA and CCSE