Commit 688892b3 authored Mar 18, 2018 by Tang Junhui Committed by Jens Axboe Mar 18, 2018

bcache: fix incorrect sysfs output value of strip size



Stripe size is shown as zero when no strip in back end device:
[root@ceph132 ~]# cat /sys/block/sdd/bcache/stripe_size
0.0k

Actually it should be 1T Bytes (1 << 31 sectors), but in sysfs
interface, stripe_size was changed from sectors to bytes, and move
9 bits left, so the 32 bits variable overflows.

This patch change the variable to a 64 bits type before moving bits.

Signed-off-by: Tang Junhui <tang.junhui@zte.com.cn>
Reviewed-by: Michael Lyle <mlyle@lyle.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent bc082a55

drivers/md/bcache/sysfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -181,7 +181,7 @@ SHOW(__bch_cached_dev)
		sysfs_hprint(dirty_data,
		bcache_dev_sectors_dirty(&dc->disk) << 9);

		sysfs_hprint(stripe_size, dc->disk.stripe_size << 9);
		sysfs_hprint(stripe_size, ((uint64_t)dc->disk.stripe_size) << 9);
		var_printf(partial_stripes_expensive, "%u");

		var_hprint(sequential_cutoff);

Admin message