Commit 68870370 authored Nov 21, 2017 by Geert Uytterhoeven Committed by David S. Miller Nov 24, 2017

net/smc: Fix preinitialization of buf_desc in __smc_buf_create()



With gcc-4.1.2:

    net/smc/smc_core.c: In function ‘__smc_buf_create’:
    net/smc/smc_core.c:567: warning: ‘bufsize’ may be used uninitialized in this function

Indeed, if the for-loop is never executed, bufsize is used
uninitialized.  In addition, buf_desc is stored for later use, while it
is still a NULL pointer.

Before, error handling was done by checking if buf_desc is non-NULL.
The cleanup changed this to an error check, but forgot to update the
preinitialization of buf_desc to an error pointer.

Update the preinitializatin of buf_desc to fix this.

Fixes: b33982c3 ("net/smc: cleanup function __smc_buf_create()")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4e1061f4

net/smc/smc_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -562,7 +562,7 @@ static int __smc_buf_create(struct smc_sock *smc, bool is_rmb)
		{
		struct smc_connection *conn = &smc->conn;
		struct smc_link_group *lgr = conn->lgr;
		struct smc_buf_desc *buf_desc = NULL;
		struct smc_buf_desc *buf_desc = ERR_PTR(-ENOMEM);
		struct list_head *buf_list;
		int bufsize, bufsize_short;
		int sk_buf_size;

Admin message