media: platform: Improve getting and requesting irq flow for bug fixing (6869a2de) · Commits · 戴 / test

Delete platform_get_resource operation for irq. Return actual value rather than EINVAL when fail to get and request irq. Reviewed-by:

drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -1103,12 +1103,10 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
		return ret;
		}

		res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
		dec_irq = platform_get_irq(pdev, 0);
		if (!res \|\| dec_irq < 0) {
		if (dec_irq < 0) {
		dev_err(&pdev->dev, "Failed to get dec_irq %d.\n", dec_irq);
		ret = -EINVAL;
		return ret;
		return dec_irq;
		}

		ret = devm_request_irq(&pdev->dev, dec_irq, mtk_jpeg_dec_irq, 0,
		@@ -1116,7 +1114,6 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
		if (ret) {
		dev_err(&pdev->dev, "Failed to request dec_irq %d (%d)\n",
		dec_irq, ret);
		ret = -EINVAL;
		goto err_req_irq;
		}