Commit 6868225e authored May 03, 2012 by Lin Ming Committed by Jeff Garzik May 03, 2012

libata: skip old error history when counting probe trials



Commit d9027470("[libata] Add ATA transport class") introduced
ATA_EFLAG_OLD_ER to mark entries in the error ring as cleared.

But ata_count_probe_trials_cb() didn't check this flag and it still
counts the old error history. So wrong probe trials count is returned
and it causes problem, for example, SATA link speed is slowed down from
3.0Gbps to 1.5Gbps.

Fix it by checking ATA_EFLAG_OLD_ER in ata_count_probe_trials_cb().

Cc: stable <stable@vger.kernel.org> # 2.6.37+
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent 69964ea4

drivers/ata/libata-eh.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -3501,7 +3501,8 @@ static int ata_count_probe_trials_cb(struct ata_ering_entry ent, void void_arg
		u64 now = get_jiffies_64();
		int *trials = void_arg;

		if (ent->timestamp < now - min(now, interval))
		if ((ent->eflags & ATA_EFLAG_OLD_ER) \|\|
		(ent->timestamp < now - min(now, interval)))
		return -1;

		(*trials)++;

Admin message