Commit 685d87f7 authored Aug 06, 2008 by Linus Torvalds

Revert "pcm_native.c: remove unused label"



This reverts commit 680db013.  The label
is actually used, but hidden behind CONFIG_SND_DEBUG and the horrible
snd_assert() macro.

That macro could probably be improved to be along the lines of

	#define snd_assert(expr, args...) do { if ((void)(expr),0) { args; } } while (0)

or similar to make sure that we always both evaluate 'expr' and parse
'args', but while gcc should optimize it all away, I'm too lazy to
really verify that.  So I'll just admit defeat and will continue to live
with the annoying warning.

Noted-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Linus "Grr.." Torvalds

parent f99e8f27

sound/core/pcm_native.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -3259,6 +3259,7 @@ static int snd_pcm_fasync(int fd, struct file * file, int on)
		runtime = substream->runtime;

		err = fasync_helper(fd, file, on, &runtime->fasync);
		out:
		unlock_kernel();
		if (err < 0)
		return err;

Admin message