Unverified Commit 6856e887 authored by Amadeusz Sławiński's avatar Amadeusz Sławiński Committed by Mark Brown
Browse files

ASoC: topology: Check soc_tplg_add_route return value 



Function soc_tplg_add_route can propagate error code from callback, we
should check its return value and handle fail in correct way.

Signed-off-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200327204729.397-5-amadeuszx.slawinski@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2ae548f3

sound/soc/soc-topology.c

+3 −1
Original line number Diff line number Diff line
@@ -1284,7 +1284,9 @@ static int soc_tplg_dapm_graph_elems_load(struct soc_tplg *tplg, 
		routes[i]->dobj.index = tplg->index;

		list_add(&routes[i]->dobj.list, &tplg->comp->dobj_list);



		soc_tplg_add_route(tplg, routes[i]);

		ret = soc_tplg_add_route(tplg, routes[i]);

		if (ret < 0)

			break;



		/* add route, but keep going if some fail */

		snd_soc_dapm_add_routes(dapm, routes[i], 1);

CRA Git | Maintained and supported by SUSTech CRA and CCSE