Commit 683a0e63 authored Sep 04, 2018 by Gustavo A. R. Silva Committed by Gerd Hoffmann Sep 05, 2018

dma-buf/udmabuf: Fix NULL pointer dereference in udmabuf_create



There is a potential execution path in which pointer memfd is NULL when
passed as argument to fput(), hence there is a NULL pointer dereference
in fput().

Fix this by null checking *memfd* before calling fput().

Addresses-Coverity-ID: 1473174 ("Explicit null dereferenced")
Fixes: fbb0de79 ("Add udmabuf misc device")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20180904190749.GA9308@embeddedor.com


Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

parent a3b815f0

drivers/dma-buf/udmabuf.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -194,6 +194,7 @@ err_put_pages:
		while (pgbuf > 0)
		put_page(ubuf->pages[--pgbuf]);
		err_free_ubuf:
		if (memfd)
		fput(memfd);
		kfree(ubuf->pages);
		kfree(ubuf);

Admin message