Commit 68202c9f authored Jul 29, 2016 by Ross Zwisler Committed by Dan Williams Aug 08, 2016

libnvdimm, nd_blk: mask off reserved status bits

The "NVDIMM Block Window Driver Writer's Guide":

    http://pmem.io/documents/NVDIMM_DriverWritersGuide-July-2016.pdf



...defines the layout of the block window status register.  For the July
2016 version of the spec linked to above, this happens in Figure 4 on
page 26.

The only bits defined in this spec are bits 31, 5, 4, 2, 1 and 0.  The
rest of the bits in the status register are reserved, and there is a
warning following the diagram that says:

    Note: The driver cannot assume the value of the RESERVED bits in the
    status register are zero. These reserved bits need to be masked off, and
    the driver must avoid checking the state of those bits.

This change ensures that for hardware implementations that set these
reserved bits in the status register, the driver won't incorrectly fail the
block I/Os.

Cc: <stable@vger.kernel.org> #v4.2+
Reviewed-by: Lee, Chun-Yi <jlee@suse.com>
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent 29b4817d

drivers/acpi/nfit/core.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1527,11 +1527,12 @@ static u32 read_blk_stat(struct nfit_blk *nfit_blk, unsigned int bw)
		{
		struct nfit_blk_mmio *mmio = &nfit_blk->mmio[DCR];
		u64 offset = nfit_blk->stat_offset + mmio->size * bw;
		const u32 STATUS_MASK = 0x80000037;

		if (mmio->num_lines)
		offset = to_interleave_offset(offset, mmio);

		return readl(mmio->addr.base + offset);
		return readl(mmio->addr.base + offset) & STATUS_MASK;
		}

		static void write_blk_ctl(struct nfit_blk *nfit_blk, unsigned int bw,

Admin message