Commit 681fda8d authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: fix recvmsg memory leak with buffer selection



io_recvmsg() doesn't free memory allocated for struct io_buffer. This can
causes a leak when used with automatic buffer selection.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 16d59803
Loading
Loading
Loading
Loading
+8 −2
Original line number Diff line number Diff line
@@ -3845,10 +3845,16 @@ static int io_recvmsg(struct io_kiocb *req, bool force_nonblock)

		ret = __sys_recvmsg_sock(sock, &kmsg->msg, req->sr_msg.msg,
						kmsg->uaddr, flags);
		if (force_nonblock && ret == -EAGAIN)
			return io_setup_async_msg(req, kmsg);
		if (force_nonblock && ret == -EAGAIN) {
			ret = io_setup_async_msg(req, kmsg);
			if (ret != -EAGAIN)
				kfree(kbuf);
			return ret;
		}
		if (ret == -ERESTARTSYS)
			ret = -EINTR;
		if (kbuf)
			kfree(kbuf);
	}

	if (kmsg && kmsg->iov != kmsg->fast_iov)