libata: correct handling of SRST reset sequences (681c80b5) · Commits · 戴 / test

Correct handling of SRST reset sequences. After an SRST it is undefined whether the drive has gone back to PIO0. In order to talk safely we should talk slowly and carefully until we know. Thus when we do the reset if the controller has a pio setup method we call it to flip back to PIO 0 and a known state. After the reset completes the identify will then be done at the safe speed and the drive/controller will pick suitable faster modes and reconfigure the controller to these timings. As a side effect it means we force the controller to PIO 0 as we bring it up which fixes funnies on a few systems where the BIOS firmware leaves us in an interesting choice of modes, or embedded boxes with no firmware which come up in random states. For smart controllers there is nothing to do - they know about this internally. Signed-off-by:

Alan Cox <alan@redhat.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Jeff Garzik <jeff@garzik.org>

drivers/ata/libata-core.c

+21 −0

Original line number	Diff line number	Diff line
		@@ -3209,6 +3209,8 @@ static int ata_bus_softreset(struct ata_port *ap, unsigned int devmask,
		unsigned long deadline)
		{
		struct ata_ioports *ioaddr = &ap->ioaddr;
		struct ata_device *dev;
		int i = 0;

		DPRINTK("ata%u: bus reset via SRST\n", ap->print_id);

		@@ -3219,6 +3221,25 @@ static int ata_bus_softreset(struct ata_port *ap, unsigned int devmask,
		udelay(20); /* FIXME: flush */
		iowrite8(ap->ctl, ioaddr->ctl_addr);

		/* If we issued an SRST then an ATA drive (not ATAPI)
		* may have changed configuration and be in PIO0 timing. If
		* we did a hard reset (or are coming from power on) this is
		* true for ATA or ATAPI. Until we've set a suitable controller
		* mode we should not touch the bus as we may be talking too fast.
		*/

		ata_link_for_each_dev(dev, &ap->link)
		dev->pio_mode = XFER_PIO_0;

		/* If the controller has a pio mode setup function then use
		it to set the chipset to rights. Don't touch the DMA setup
		as that will be dealt with when revalidating */
		if (ap->ops->set_piomode) {
		ata_link_for_each_dev(dev, &ap->link)
		if (devmask & (1 << i++))
		ap->ops->set_piomode(ap, dev);
		}

		/* spec mandates ">= 2ms" before checking status.
		* We wait 150ms, because that was the magic delay used for
		* ATAPI devices in Hale Landis's ATADRVR, for the period of time

Admin message