Commit 67eed44b authored by Amit Kucheria's avatar Amit Kucheria Committed by Zhang Rui
Browse files

thermal: Add some error messages 



When registering a thermal zone device, we currently return -EINVAL in
four cases. This makes it a little hard to debug the real cause of the
failure.

Print some error messages to make it easier for developer to figure out
what happened.

Signed-off-by: default avatarAmit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: default avatarZhang Rui <rui.zhang@intel.com>
parent 1851799e

drivers/thermal/thermal_core.c

+13 −4
Original line number Diff line number Diff line
@@ -1245,17 +1245,26 @@ thermal_zone_device_register(const char *type, int trips, int mask, 
	int count;

	struct thermal_governor *governor;



	if (!type || strlen(type) == 0)

	if (!type || strlen(type) == 0) {

		pr_err("Error: No thermal zone type defined\n");

		return ERR_PTR(-EINVAL);

	}



	if (type && strlen(type) >= THERMAL_NAME_LENGTH)

	if (type && strlen(type) >= THERMAL_NAME_LENGTH) {

		pr_err("Error: Thermal zone name (%s) too long, should be under %d chars\n",

		       type, THERMAL_NAME_LENGTH);

		return ERR_PTR(-EINVAL);

	}



	if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips)

	if (trips > THERMAL_MAX_TRIPS || trips < 0 || mask >> trips) {

		pr_err("Error: Incorrect number of thermal trips\n");

		return ERR_PTR(-EINVAL);

	}



	if (!ops)

	if (!ops) {

		pr_err("Error: Thermal zone device ops not defined\n");

		return ERR_PTR(-EINVAL);

	}



	if (trips > 0 && (!ops->get_trip_type || !ops->get_trip_temp))

		return ERR_PTR(-EINVAL);

CRA Git | Maintained and supported by SUSTech CRA and CCSE