Commit 67cf13ce authored Oct 13, 2014 by Mike Travis Committed by Linus Torvalds Oct 14, 2014

x86: optimize resource lookups for ioremap



We have a large university system in the UK that is experiencing very long
delays modprobing the driver for a specific I/O device.  The delay is from
8-10 minutes per device and there are 31 devices in the system.  This 4 to
5 hour delay in starting up those I/O devices is very much a burden on the
customer.

There are two causes for requiring a restart/reload of the drivers.  First
is periodic preventive maintenance (PM) and the second is if any of the
devices experience a fatal error.  Both of these trigger this excessively
long delay in bringing the system back up to full capability.

The problem was tracked down to a very slow IOREMAP operation and the
excessively long ioresource lookup to insure that the user is not
attempting to ioremap RAM.  These patches provide a speed up to that
function.

The modprobe time appears to be affected quite a bit by previous activity
on the ioresource list, which I suspect is due to cache preloading.  While
the overall improvement is impacted by other overhead of starting the
devices, this drastically improves the modprobe time.

Also our system is considerably smaller so the percentages gained will not
be the same.  Best case improvement with the modprobe on our 20 device
smallish system was from 'real 5m51.913s' to 'real 0m18.275s'.

This patch (of 2):

Since the ioremap operation is verifying that the specified address range
is NOT RAM, it will search the entire ioresource list if the condition is
true.  To make matters worse, it does this one 4k page at a time.  For a
128M BAR region this is 32 passes to determine the entire region does not
contain any RAM addresses.

This patch provides another resource lookup function, region_is_ram, that
searches for the entire region specified, verifying that it is completely
contained within the resource region.  If it is found, then it is checked
to be RAM or not, within a single pass.

The return result reflects if it was found or not (-1), and whether it is
RAM (1) or not (0).  This allows the caller to fallback to the previous
page by page search if it was not found.

[akpm@linux-foundation.org: fix spellos and typos in comment]
Signed-off-by: Mike Travis <travis@sgi.com>
Acked-by: Alex Thorlton <athorlton@sgi.com>
Reviewed-by: Cliff Wickman <cpw@sgi.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Mark Salter <msalter@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 76e51210

include/linux/mm.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -347,6 +347,7 @@ static inline int put_page_unless_one(struct page *page)
		}

		extern int page_is_ram(unsigned long pfn);
		extern int region_is_ram(resource_size_t phys_addr, unsigned long size);

		/* Support for virtually mapped pages */
		struct page vmalloc_to_page(const void addr);

kernel/resource.c

+36 −0

Original line number	Diff line number	Diff line
		@@ -491,6 +491,42 @@ int __weak page_is_ram(unsigned long pfn)
		}
		EXPORT_SYMBOL_GPL(page_is_ram);

		/*
		* Search for a resouce entry that fully contains the specified region.
		* If found, return 1 if it is RAM, 0 if not.
		* If not found, or region is not fully contained, return -1
		*
		* Used by the ioremap functions to ensure the user is not remapping RAM and is
		* a vast speed up over walking through the resource table page by page.
		*/
		int region_is_ram(resource_size_t start, unsigned long size)
		{
		struct resource *p;
		resource_size_t end = start + size - 1;
		int flags = IORESOURCE_MEM \| IORESOURCE_BUSY;
		const char *name = "System RAM";
		int ret = -1;

		read_lock(&resource_lock);
		for (p = iomem_resource.child; p ; p = p->sibling) {
		if (end < p->start)
		continue;

		if (p->start <= start && end <= p->end) {
		/* resource fully contains region */
		if ((p->flags != flags) \|\| strcmp(p->name, name))
		ret = 0;
		else
		ret = 1;
		break;
		}
		if (p->end < start)
		break; /* not found */
		}
		read_unlock(&resource_lock);
		return ret;
		}

		void __weak arch_remove_reservations(struct resource *avail)
		{
		}

Admin message