Commit 67ceb1ec authored Mar 07, 2019 by Hou Tao Committed by Linus Torvalds Mar 07, 2019

fat: enable .splice_write to support splice on O_DIRECT file

Now splice() on O_DIRECT-opened fat file will return -EFAULT, that is
because the default .splice_write, namely default_file_splice_write(),
will construct an ITER_KVEC iov_iter and dio_refill_pages() in dio path
can not handle it.

Fix it by implementing .splice_write through iter_file_splice_write().

Spotted by xfs-tests generic/091.

Link: http://lkml.kernel.org/r/20190210094754.56355-1-houtao1@huawei.com


Signed-off-by: Hou Tao <houtao1@huawei.com>
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 660c9fc7

fs/fat/file.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -214,6 +214,7 @@ const struct file_operations fat_file_operations = {
		#endif
		.fsync = fat_file_fsync,
		.splice_read = generic_file_splice_read,
		.splice_write = iter_file_splice_write,
		.fallocate = fat_fallocate,
		};

Admin message