Commit 67b16684 authored Aug 03, 2014 by Guennadi Liakhovetski Committed by Vinod Koul Aug 04, 2014

dmaengine: nbpfaxi: fix a theoretical race

A race possibility exists if a DMA slave driver tries to free channel
resources witout waiting for all transfers to complete and without
explicitly terminating all requests. In such a case the IRQ processing
thread can race with .device_free_chan_resources(). To fix this race empty
all descriptor lists before freeing descriptor cache.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent b45b262c

drivers/dma/nbpfaxi.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1054,6 +1054,7 @@ static void nbpf_free_chan_resources(struct dma_chan *dchan)
		dev_dbg(dchan->device->dev, "Entry %s()\n", __func__);

		nbpf_chan_halt(chan);
		nbpf_chan_idle(chan);
		/* Clean up for if a channel is re-used for MEMCPY after slave DMA */
		nbpf_chan_prepare_default(chan);

Admin message