Commit 67aa291b authored by Tuomas Tynkkynen's avatar Tuomas Tynkkynen Committed by Greg Kroah-Hartman
Browse files

staging: vc04_services: Drop trivially unused fields from SERVICE_CREATION_T 



These fields are only initialized with constants and never read. Drop
them.

Signed-off-by: default avatarTuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
Acked-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 22ad7f6b

drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c

+0 −5
Original line number Diff line number Diff line
@@ -130,13 +130,8 @@ vc_vchi_audio_init(VCHI_INSTANCE_T vchi_instance, 
	SERVICE_CREATION_T params = {

		.version		= VCHI_VERSION_EX(VC_AUDIOSERV_VER, VC_AUDIOSERV_MIN_VER),

		.service_id		= VC_AUDIO_SERVER_NAME,

		.rx_fifo_size		= 0,

		.tx_fifo_size		= 0,

		.callback		= audio_vchi_callback,

		.callback_param		= instance,

		.want_unaligned_bulk_rx = 1, //TODO: remove VCOS_FALSE

		.want_unaligned_bulk_tx = 1, //TODO: remove VCOS_FALSE

		.want_crc		= 0

	};

	int status;

drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c

+0 −5
Original line number Diff line number Diff line
@@ -1806,13 +1806,8 @@ int vchiq_mmal_init(struct vchiq_mmal_instance **out_instance) 
	SERVICE_CREATION_T params = {

		.version		= VCHI_VERSION_EX(VC_MMAL_VER, VC_MMAL_MIN_VER),

		.service_id		= VC_MMAL_SERVER_NAME,

		.rx_fifo_size		= 0,

		.tx_fifo_size		= 0,

		.callback		= service_callback,

		.callback_param		= NULL,

		.want_unaligned_bulk_rx = 1,

		.want_unaligned_bulk_tx = 1,

		.want_crc		= 0

	};



	/* compile time checks to ensure structure size as they are

drivers/staging/vc04_services/interface/vchi/vchi.h

+0 −11
Original line number Diff line number Diff line
@@ -77,19 +77,8 @@ typedef struct { 
typedef struct {

	struct vchi_version version;

	int32_t service_id;

	uint32_t rx_fifo_size;

	uint32_t tx_fifo_size;

	VCHI_CALLBACK_T callback;

	void *callback_param;

	/* client intends to receive bulk transfers of

		odd lengths or into unaligned buffers */

	int32_t want_unaligned_bulk_rx;

	/* client intends to transmit bulk transfers of

		odd lengths or out of unaligned buffers */

	int32_t want_unaligned_bulk_tx;

	/* client wants to check CRCs on (bulk) xfers.

		Only needs to be set at 1 end - will do both directions. */

	int32_t want_crc;

} SERVICE_CREATION_T;



// Opaque handle for a VCHI instance

CRA Git | Maintained and supported by SUSTech CRA and CCSE