Commit 6798df4c authored May 03, 2016 by Jiri Slaby Committed by Greg Kroah-Hartman May 03, 2016

tty: vt, return error when con_startup fails



When csw->con_startup() fails in do_register_con_driver, we return no
error (i.e. 0). This was changed back in 2006 by commit 3e795de7.
Before that we used to return -ENODEV.

So fix the return value to be -ENODEV in that case again.

Fixes: 3e795de7 ("VT binding: Add binding/unbinding support for the VT console")
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: "Dan Carpenter" <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 11ca2b7a

drivers/tty/vt/vt.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -3594,9 +3594,10 @@ static int do_register_con_driver(const struct consw *csw, int first, int last)
		goto err;

		desc = csw->con_startup();

		if (!desc)
		if (!desc) {
		retval = -ENODEV;
		goto err;
		}

		retval = -EINVAL;

Admin message