Commit 6791457a authored Jul 18, 2012 by Vivek Goyal Committed by Greg Kroah-Hartman Jul 19, 2012

printk: Export struct log size and member offsets through vmcoreinfo



There are tools like makedumpfile and vmcore-dmesg which can extract
kernel log buffer from vmcore. Since we introduced structured logging,
that functionality is broken. Now user space tools need to know about
"struct log" and offsets of various fields to be able to parse struct
log data and extract text message or dictonary.

This patch exports some of the fields.

Currently I am not exporting log "level" info as that is a bitfield and
offsetof() bitfields can't be calculated. But if people start asking for
log level info in the output then we probably either need to seprate
out "level" or use bit shift operations for flags and level.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Acked-by: Kay Sievers <kay@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent bd8a4f06

kernel/printk.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -671,6 +671,15 @@ void log_buf_kexec_setup(void)
		VMCOREINFO_SYMBOL(log_buf_len);
		VMCOREINFO_SYMBOL(log_first_idx);
		VMCOREINFO_SYMBOL(log_next_idx);
		/*
		* Export struct log size and field offsets. User space tools can
		* parse it and detect any changes to structure down the line.
		*/
		VMCOREINFO_STRUCT_SIZE(log);
		VMCOREINFO_OFFSET(log, ts_nsec);
		VMCOREINFO_OFFSET(log, len);
		VMCOREINFO_OFFSET(log, text_len);
		VMCOREINFO_OFFSET(log, dict_len);
		}
		#endif

Admin message