Commit 678e2757 authored Oct 01, 2014 by Christoph Hellwig

scsi: PC partition tables are little endian

As sparse correctly pointed out, scsi_partsize should use get_unaligned_le32
to read PC partition tables from disk, as they are little endian.

The result of this bug is that we returned incorrect geometries on big
endian systems when using the scsicam variant. Which probably doesn't
matter as only old x86 systems every cared about the geometry.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>

parent 037e6d86

drivers/scsi/scsicam.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -163,8 +163,8 @@ int scsi_partsize(unsigned char *buf, unsigned long capacity,
		end_head * end_sector + end_sector;

		/* This is the actual _sector_ number at the end */
		logical_end = get_unaligned(&largest->start_sect)
		+ get_unaligned(&largest->nr_sects);
		logical_end = get_unaligned_le32(&largest->start_sect)
		+ get_unaligned_le32(&largest->nr_sects);

		/* This is for >1023 cylinders */
		ext_cyl = (logical_end - (end_head * end_sector + end_sector))

Admin message