Commit 677d8537 authored Jul 05, 2011 by Jeff Layton Committed by Steve French Jul 06, 2011

cifs: remove bogus call to cifs_cleanup_volume_info



This call to cifs_cleanup_volume_info is clearly wrong. As soon as it's
called the following call to cifs_get_tcp_session will oops as the
volume_info pointer will then be NULL.

The caller of cifs_mount should clean up this data since it passed it
in. There's no need for us to call this here.

Regression introduced by commit 724d9f1c.

Reported-by: Adam Williamson <awilliam@redhat.com>
Cc: Pavel Shilovsky <piastryyy@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent de3796e7

fs/cifs/connect.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -3012,7 +3012,6 @@ try_mount_again:
		else if (pSesInfo)
		cifs_put_smb_ses(pSesInfo);

		cifs_cleanup_volume_info(&volume_info);
		FreeXid(xid);
		}
		#endif

Admin message