Commit 67796bf7 authored by Joerg Roedel's avatar Joerg Roedel
Browse files

x86/dma: unify definition of pci_unmap_addr* and pci_unmap_len macros 



Impact: unification of pci-dma macros and pci_32.h removal

This patch unifies the definition of the pci_unmap_addr*, pci_unmap_len*
and DECLARE_PCI_UNMAP* macros. This makes sense because the pci_unmap
functions are no longer no-ops anymore when the kernel runs with
CONFIG_DMA_API_DEBUG. Without an iommu or DMA_API_DEBUG it is a no-op on 32 bit
because the dma mapping path returns a physical address and therefore the
dma-api implementation has no internal state which needs to be destroyed with
an unmap call.
This unification also simplifies the port of x86_64 iommu drivers to 32 bit x86
and let us get rid of pci_32.h.

Signed-off-by: default avatarJoerg Roedel <joerg.roedel@amd.com>
Acked-by: default avatarStephen Hemminger <shemminger@vyatta.com>
parent 8fe74cf0

arch/x86/include/asm/pci.h

+32 −4
Original line number Diff line number Diff line
@@ -89,11 +89,39 @@ extern void pci_iommu_alloc(void); 
/* MSI arch hook */

#define arch_setup_msi_irqs arch_setup_msi_irqs



#endif  /* __KERNEL__ */

#define PCI_DMA_BUS_IS_PHYS (dma_ops->is_phys)



#if defined(CONFIG_X86_64) || defined(CONFIG_DMA_API_DEBUG)



#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME)       \

	        dma_addr_t ADDR_NAME;

#define DECLARE_PCI_UNMAP_LEN(LEN_NAME)         \

	        __u32 LEN_NAME;

#define pci_unmap_addr(PTR, ADDR_NAME)                  \

	        ((PTR)->ADDR_NAME)

#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL)         \

	        (((PTR)->ADDR_NAME) = (VAL))

#define pci_unmap_len(PTR, LEN_NAME)                    \

	        ((PTR)->LEN_NAME)

#define pci_unmap_len_set(PTR, LEN_NAME, VAL)           \

	        (((PTR)->LEN_NAME) = (VAL))



#ifdef CONFIG_X86_32

# include "pci_32.h"

#else



#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME)       dma_addr_t ADDR_NAME[0];

#define DECLARE_PCI_UNMAP_LEN(LEN_NAME) unsigned LEN_NAME[0];

#define pci_unmap_addr(PTR, ADDR_NAME)  sizeof((PTR)->ADDR_NAME)

#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL) \

	        do { break; } while (pci_unmap_addr(PTR, ADDR_NAME))

#define pci_unmap_len(PTR, LEN_NAME)            sizeof((PTR)->LEN_NAME)

#define pci_unmap_len_set(PTR, LEN_NAME, VAL) \

	        do { break; } while (pci_unmap_len(PTR, LEN_NAME))



#endif



#endif  /* __KERNEL__ */



#ifdef CONFIG_X86_64

#include "pci_64.h"

#endif

arch/x86/include/asm/pci_32.h

deleted100644 → 0
+0 −34
Original line number Diff line number Diff line 
#ifndef _ASM_X86_PCI_32_H

#define _ASM_X86_PCI_32_H





#ifdef __KERNEL__





/* Dynamic DMA mapping stuff.

 * i386 has everything mapped statically.

 */



struct pci_dev;



/* The PCI address space does equal the physical memory

 * address space.  The networking and block device layers use

 * this boolean for bounce buffer decisions.

 */

#define PCI_DMA_BUS_IS_PHYS	(1)



/* pci_unmap_{page,single} is a nop so... */

#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME)	dma_addr_t ADDR_NAME[0];

#define DECLARE_PCI_UNMAP_LEN(LEN_NAME)	unsigned LEN_NAME[0];

#define pci_unmap_addr(PTR, ADDR_NAME)	sizeof((PTR)->ADDR_NAME)

#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL) \

	do { break; } while (pci_unmap_addr(PTR, ADDR_NAME))

#define pci_unmap_len(PTR, LEN_NAME)		sizeof((PTR)->LEN_NAME)

#define pci_unmap_len_set(PTR, LEN_NAME, VAL) \

	do { break; } while (pci_unmap_len(PTR, LEN_NAME))





#endif /* __KERNEL__ */





#endif /* _ASM_X86_PCI_32_H */

arch/x86/include/asm/pci_64.h

+0 −22
Original line number Diff line number Diff line
@@ -24,28 +24,6 @@ extern int (*pci_config_write)(int seg, int bus, int dev, int fn, 


extern void dma32_reserve_bootmem(void);



/* The PCI address space does equal the physical memory

 * address space.  The networking and block device layers use

 * this boolean for bounce buffer decisions

 *

 * On AMD64 it mostly equals, but we set it to zero if a hardware

 * IOMMU (gart) of sotware IOMMU (swiotlb) is available.

 */

#define PCI_DMA_BUS_IS_PHYS (dma_ops->is_phys)



#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME)	\

	dma_addr_t ADDR_NAME;

#define DECLARE_PCI_UNMAP_LEN(LEN_NAME)		\

	__u32 LEN_NAME;

#define pci_unmap_addr(PTR, ADDR_NAME)			\

	((PTR)->ADDR_NAME)

#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL)		\

	(((PTR)->ADDR_NAME) = (VAL))

#define pci_unmap_len(PTR, LEN_NAME)			\

	((PTR)->LEN_NAME)

#define pci_unmap_len_set(PTR, LEN_NAME, VAL)		\

	(((PTR)->LEN_NAME) = (VAL))



#endif /* __KERNEL__ */



#endif /* _ASM_X86_PCI_64_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE