Commit 67626c93 authored Dec 18, 2016 by Aniroop Mathur Committed by Dmitry Torokhov Dec 18, 2016

Input: synaptics_i2c - change msleep to usleep_range for small msecs



msleep(1~20) may not do what the caller intends, and will often sleep longer.
(~20 ms actual sleep for any value given in the 1~20ms range)
This is not the desired behaviour for many cases like device resume time,
device suspend time, device enable time, retry logic, etc.
Thus, change msleep to usleep_range for precise wakeups.

Signed-off-by: Aniroop Mathur <a.mathur@samsung.com>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 41c567a5

drivers/input/mouse/synaptics_i2c.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -29,7 +29,7 @@
		* after soft reset, we should wait for 1 ms
		* before the device becomes operational
		*/
		#define SOFT_RESET_DELAY_MS 3
		#define SOFT_RESET_DELAY_US 3000
		/* and after hard reset, we should wait for max 500ms */
		#define HARD_RESET_DELAY_MS 500

		@@ -311,7 +311,7 @@ static int synaptics_i2c_reset_config(struct i2c_client *client)
		if (ret) {
		dev_err(&client->dev, "Unable to reset device\n");
		} else {
		msleep(SOFT_RESET_DELAY_MS);
		usleep_range(SOFT_RESET_DELAY_US, SOFT_RESET_DELAY_US + 100);
		ret = synaptics_i2c_config(client);
		if (ret)
		dev_err(&client->dev, "Unable to config device\n");

Admin message