Commit 6744557b authored Nov 30, 2018 by Darrick J. Wong

vfs: allow some remap flags to be passed to vfs_clone_file_range



In overlayfs, ovl_remap_file_range calls vfs_clone_file_range on the
lower filesystem's inode, passing through whatever remap flags it got
from its caller.  Since vfs_copy_file_range first tries a filesystem's
remap function with REMAP_FILE_CAN_SHORTEN, this can get passed through
to the second vfs_copy_file_range call, and this isn't an issue.
Change the WARN_ON to look only for the DEDUP flag.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

parent 7d048df4

fs/read_write.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1956,7 +1956,7 @@ loff_t do_clone_file_range(struct file *file_in, loff_t pos_in,
		struct inode *inode_out = file_inode(file_out);
		loff_t ret;

		WARN_ON_ONCE(remap_flags);
		WARN_ON_ONCE(remap_flags & REMAP_FILE_DEDUP);

		if (S_ISDIR(inode_in->i_mode) \|\| S_ISDIR(inode_out->i_mode))
		return -EISDIR;

Admin message