Commit 6713c3aa authored May 13, 2015 by Wanpeng Li Committed by Ingo Molnar Jun 19, 2015

sched: Remove superfluous resetting of the p->dl_throttled flag



Resetting the p->dl_throttled flag in rt_mutex_setprio() (for a task that is going
to be boosted) is superfluous, as the natural place to do so is in
replenish_dl_entity().

If the task was on the runqueue and it is boosted by a DL task, it will be enqueued
back with ENQUEUE_REPLENISH flag set, which can guarantee that dl_throttled is
reset in replenish_dl_entity().

This patch drops the resetting of throttled status in function rt_mutex_setprio().

Signed-off-by: Wanpeng Li <wanpeng.li@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Juri Lelli <juri.lelli@arm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1431496867-4194-6-git-send-email-wanpeng.li@linux.intel.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 178a4d23

kernel/sched/core.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -3099,7 +3099,6 @@ void rt_mutex_setprio(struct task_struct *p, int prio)
		if (!dl_prio(p->normal_prio) \|\|
		(pi_task && dl_entity_preempt(&pi_task->dl, &p->dl))) {
		p->dl.dl_boosted = 1;
		p->dl.dl_throttled = 0;
		enqueue_flag = ENQUEUE_REPLENISH;
		} else
		p->dl.dl_boosted = 0;

Admin message