tipc: Don't initialize link selector field in fragmented messages (670c5408) · Commits · 戴 / test

Eliminates code that sets the link selector field in the header of fragmented messages, since this information is never referenced. (The unnecessary initialization was harmless as it was over-written by the fragmented message identifier value before the fragments were transmitted.) Signed-off-by:

Allan Stephens <allan.stephens@windriver.com> Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com>

net/tipc/link.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1169,7 +1169,6 @@ again:

		tipc_msg_init(&fragm_hdr, MSG_FRAGMENTER, FIRST_FRAGMENT,
		INT_H_SIZE, msg_destnode(hdr));
		msg_set_link_selector(&fragm_hdr, sender->ref);
		msg_set_size(&fragm_hdr, max_pkt);
		msg_set_fragm_no(&fragm_hdr, 1);

		@@ -2427,7 +2426,6 @@ static int link_send_long_buf(struct link l_ptr, struct sk_buff buf)

		tipc_msg_init(&fragm_hdr, MSG_FRAGMENTER, FIRST_FRAGMENT,
		INT_H_SIZE, destaddr);
		msg_set_link_selector(&fragm_hdr, msg_link_selector(inmsg));
		msg_set_long_msgno(&fragm_hdr, mod(l_ptr->long_msg_seq_no++));
		msg_set_fragm_no(&fragm_hdr, fragm_no);
		l_ptr->stats.sent_fragmented++;

Admin message