Commit 66f82095 authored Jul 17, 2019 by Cong Wang Committed by David S. Miller Jul 17, 2019

fib: relax source validation check for loopback packets



In a rare case where we redirect local packets from veth to lo,
these packets fail to pass the source validation when rp_filter
is turned on, as the tracing shows:

  <...>-311708 [040] ..s1 7951180.957825: fib_table_lookup: table 254 oif 0 iif 1 src 10.53.180.130 dst 10.53.180.130 tos 0 scope 0 flags 0
  <...>-311708 [040] ..s1 7951180.957826: fib_table_lookup_nh: nexthop dev eth0 oif 4 src 10.53.180.130

So, the fib table lookup returns eth0 as the nexthop even though
the packets are local and should be routed to loopback nonetheless,
but they can't pass the dev match check in fib_info_nh_uses_dev()
without this patch.

It should be safe to relax this check for this special case, as
normally packets coming out of loopback device still have skb_dst
so they won't even hit this slow path.

Cc: Julian Anastasov <ja@ssi.bg>
Cc: David Ahern <dsahern@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f1bf3e2a

net/ipv4/fib_frontend.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -388,6 +388,11 @@ static int __fib_validate_source(struct sk_buff *skb, __be32 src, __be32 dst,
		fib_combine_itag(itag, &res);

		dev_match = fib_info_nh_uses_dev(res.fi, dev);
		/* This is not common, loopback packets retain skb_dst so normally they
		* would not even hit this slow path.
		*/
		dev_match = dev_match \|\| (res.type == RTN_LOCAL &&
		dev == net->loopback_dev);
		if (dev_match) {
		ret = FIB_RES_NHC(res)->nhc_scope >= RT_SCOPE_HOST;
		return ret;

Admin message