Commit 66d95064 authored by Jerome Brunet's avatar Jerome Brunet Committed by Stephen Boyd
Browse files

clk: walk orphan list on clock provider registration 



So far, we walked the orphan list every time a new clock was registered
in CCF. This was fine since the clocks were only referenced by name.

Now that the clock can be referenced through DT, it is not enough:
* Controller A register first a reference clocks from controller B
  through DT.
* Controller B register all its clocks then register the provider.

Each time controller B registers a new clock, the orphan list is walked
but it can't match since the provider is registered yet. When the
provider is finally registered, the orphan list is not walked unless
another clock is registered afterward.

This can lead to situation where some clocks remain orphaned even if
the parent is available.

Walking the orphan list on provider registration solves the problem.

Reported-by: default avatarJian Hu <jian.hu@amlogic.com>
Fixes: fc0c209c ("clk: Allow parents to be specified without string names")
Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
Link: https://lkml.kernel.org/r/20191203080805.104628-1-jbrunet@baylibre.com


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent e42617b8

drivers/clk/clk.c

+40 −22
Original line number Diff line number Diff line
@@ -3249,6 +3249,41 @@ static inline void clk_debug_unregister(struct clk_core *core) 
}

#endif



static void clk_core_reparent_orphans_nolock(void)

{

	struct clk_core *orphan;

	struct hlist_node *tmp2;



	/*

	 * walk the list of orphan clocks and reparent any that newly finds a

	 * parent.

	 */

	hlist_for_each_entry_safe(orphan, tmp2, &clk_orphan_list, child_node) {

		struct clk_core *parent = __clk_init_parent(orphan);



		/*

		 * We need to use __clk_set_parent_before() and _after() to

		 * to properly migrate any prepare/enable count of the orphan

		 * clock. This is important for CLK_IS_CRITICAL clocks, which

		 * are enabled during init but might not have a parent yet.

		 */

		if (parent) {

			/* update the clk tree topology */

			__clk_set_parent_before(orphan, parent);

			__clk_set_parent_after(orphan, parent, NULL);

			__clk_recalc_accuracies(orphan);

			__clk_recalc_rates(orphan, 0);

		}

	}

}



static void clk_core_reparent_orphans(void)

{

	clk_prepare_lock();

	clk_core_reparent_orphans_nolock();

	clk_prepare_unlock();

}



/**

 * __clk_core_init - initialize the data structures in a struct clk_core

 * @core:	clk_core being initialized
@@ -3259,8 +3294,6 @@ static inline void clk_debug_unregister(struct clk_core *core) 
static int __clk_core_init(struct clk_core *core)

{

	int ret;

	struct clk_core *orphan;

	struct hlist_node *tmp2;

	unsigned long rate;



	if (!core)
@@ -3407,27 +3440,8 @@ static int __clk_core_init(struct clk_core *core) 
		clk_enable_unlock(flags);

	}



	/*

	 * walk the list of orphan clocks and reparent any that newly finds a

	 * parent.

	 */

	hlist_for_each_entry_safe(orphan, tmp2, &clk_orphan_list, child_node) {

		struct clk_core *parent = __clk_init_parent(orphan);

	clk_core_reparent_orphans_nolock();



		/*

		 * We need to use __clk_set_parent_before() and _after() to

		 * to properly migrate any prepare/enable count of the orphan

		 * clock. This is important for CLK_IS_CRITICAL clocks, which

		 * are enabled during init but might not have a parent yet.

		 */

		if (parent) {

			/* update the clk tree topology */

			__clk_set_parent_before(orphan, parent);

			__clk_set_parent_after(orphan, parent, NULL);

			__clk_recalc_accuracies(orphan);

			__clk_recalc_rates(orphan, 0);

		}

	}



	kref_init(&core->ref);

out:
@@ -4274,6 +4288,8 @@ int of_clk_add_provider(struct device_node *np, 
	mutex_unlock(&of_clk_mutex);

	pr_debug("Added clock from %pOF\n", np);



	clk_core_reparent_orphans();



	ret = of_clk_set_defaults(np, true);

	if (ret < 0)

		of_clk_del_provider(np);
@@ -4309,6 +4325,8 @@ int of_clk_add_hw_provider(struct device_node *np, 
	mutex_unlock(&of_clk_mutex);

	pr_debug("Added clk_hw provider from %pOF\n", np);



	clk_core_reparent_orphans();



	ret = of_clk_set_defaults(np, true);

	if (ret < 0)

		of_clk_del_provider(np);

CRA Git | Maintained and supported by SUSTech CRA and CCSE