Commit 66d5477d authored by Martin Brandenburg's avatar Martin Brandenburg Committed by Mike Marshall
Browse files

orangefs: do not invalidate attributes on inode create 



When an inode is created, we fetch attributes from the server.  There is
no need to turn around and invalidate them.

No need to initialize attributes after the getattr either.  Either it'll
be exactly the same, or it'll be something else and wrong.

Signed-off-by: default avatarMartin Brandenburg <martin@omnibond.com>
Signed-off-by: default avatarMike Marshall <hubcap@omnibond.com>
parent fc2e2e9c

fs/orangefs/inode.c

+0 −6
Original line number Diff line number Diff line
@@ -460,12 +460,6 @@ struct inode *orangefs_new_inode(struct super_block *sb, struct inode *dir, 
		goto out_iput;



	orangefs_init_iops(inode);



	inode->i_mode = mode;

	inode->i_uid = current_fsuid();

	inode->i_gid = current_fsgid();

	inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode);

	inode->i_size = PAGE_SIZE;

	inode->i_rdev = dev;



	error = insert_inode_locked4(inode, hash, orangefs_test_inode, ref);

fs/orangefs/namei.c

+0 −6
Original line number Diff line number Diff line
@@ -76,8 +76,6 @@ static int orangefs_create(struct inode *dir, 


	d_instantiate_new(dentry, inode);

	orangefs_set_timeout(dentry);

	ORANGEFS_I(inode)->getattr_time = jiffies - 1;

	ORANGEFS_I(inode)->getattr_mask = STATX_BASIC_STATS;



	gossip_debug(GOSSIP_NAME_DEBUG,

		     "%s: dentry instantiated for %pd\n",
@@ -291,8 +289,6 @@ static int orangefs_symlink(struct inode *dir, 


	d_instantiate_new(dentry, inode);

	orangefs_set_timeout(dentry);

	ORANGEFS_I(inode)->getattr_time = jiffies - 1;

	ORANGEFS_I(inode)->getattr_mask = STATX_BASIC_STATS;



	gossip_debug(GOSSIP_NAME_DEBUG,

		     "Inode (Symlink) %pU -> %pd\n",
@@ -360,8 +356,6 @@ static int orangefs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode 


	d_instantiate_new(dentry, inode);

	orangefs_set_timeout(dentry);

	ORANGEFS_I(inode)->getattr_time = jiffies - 1;

	ORANGEFS_I(inode)->getattr_mask = STATX_BASIC_STATS;



	gossip_debug(GOSSIP_NAME_DEBUG,

		     "Inode (Directory) %pU -> %pd\n",

CRA Git | Maintained and supported by SUSTech CRA and CCSE