Commit 66c6afbd authored Dec 14, 2018 by Colin Ian King Committed by Christoph Hellwig Dec 18, 2018

nvmet: fix comparison of a u16 with -1



Currently the u16 req->error_loc is being compared to -1 which
will always be false.  Fix this by casting -1 to u16 to fix this.

Detected by clang:
  warning: result of comparison of constant -1 with expression of
  type 'u16' (aka 'unsigned short') is always false
  [-Wtautological-constant-out-of-range-compare]

Fixes: 76574f37 ("nvmet: add interface to update error-log page")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent cd19181b

drivers/nvme/target/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -663,7 +663,7 @@ static void nvmet_set_error(struct nvmet_req *req, u16 status)

		req->rsp->status = cpu_to_le16(status << 1);

		if (!ctrl \|\| req->error_loc == -1)
		if (!ctrl \|\| req->error_loc == (u16)-1)
		return;

		spin_lock_irqsave(&ctrl->error_lock, flags);

Admin message