Commit 664134d2 authored Nov 25, 2008 by Ingo Molnar Committed by Herbert Xu Dec 25, 2008

crypto: testmgr - Fix error flow of test_comp



This warning:

  crypto/testmgr.c: In function ‘test_comp’:
  crypto/testmgr.c:829: warning: ‘ret’ may be used uninitialized in this function

triggers because GCC correctly notices that in the ctcount == 0 &&
dtcount != 0 input condition case this function can return an undefined
value, if the second loop fails.

Remove the shadowed 'ret' variable from the second loop that was probably
unintended.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 5f459f0a

crypto/testmgr.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -853,7 +853,7 @@ static int test_comp(struct crypto_comp tfm, struct comp_testvec ctemplate,
		}

		for (i = 0; i < dtcount; i++) {
		int ilen, ret, dlen = COMP_BUF_SIZE;
		int ilen, dlen = COMP_BUF_SIZE;

		memset(result, 0, sizeof (result));

Admin message