Commit 6629400a authored by David Howells's avatar David Howells Committed by Steve French
Browse files

cifs: Don't use iov_iter::type directly 



Don't use iov_iter::type directly, but rather use the new accessor
functions that have been added.  This allows the .type field to be split
and rearranged without the need to update the filesystems.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 731b82bb

fs/cifs/file.c

+4 −4
Original line number Diff line number Diff line
@@ -2921,7 +2921,7 @@ cifs_write_from_iter(loff_t offset, size_t len, struct iov_iter *from, 
					"direct_writev couldn't get user pages "

					"(rc=%zd) iter type %d iov_offset %zd "

					"count %zd\n",

					result, from->type,

					result, iov_iter_type(from),

					from->iov_offset, from->count);

				dump_stack();
@@ -3132,7 +3132,7 @@ static ssize_t __cifs_writev( 
	 * In this case, fall back to non-direct write function.

	 * this could be improved by getting pages directly in ITER_KVEC

	 */

	if (direct && from->type & ITER_KVEC) {

	if (direct && iov_iter_is_kvec(from)) {

		cifs_dbg(FYI, "use non-direct cifs_writev for kvec I/O\n");

		direct = false;

	}
@@ -3652,7 +3652,7 @@ cifs_send_async_read(loff_t offset, size_t len, struct cifsFileInfo *open_file, 
					"couldn't get user pages (rc=%zd)"

					" iter type %d"

					" iov_offset %zd count %zd\n",

					result, direct_iov.type,

					result, iov_iter_type(&direct_iov),

					direct_iov.iov_offset,

					direct_iov.count);

				dump_stack();
@@ -3863,7 +3863,7 @@ static ssize_t __cifs_readv( 
	 * fall back to data copy read path

	 * this could be improved by getting pages directly in ITER_KVEC

	 */

	if (direct && to->type & ITER_KVEC) {

	if (direct && iov_iter_is_kvec(to)) {

		cifs_dbg(FYI, "use non-direct cifs_user_readv for kvec I/O\n");

		direct = false;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE