net/mlx5: Add meaningful return codes to status_to_err function (661f0312) · Commits · 戴 / test

Current version of function status_to_err return -1 for any status returned by mlx5_cmd_invoke function. In case status is MLX5_DRIVER_STATUS_ABORTED we should return 0 to the caller as we assume command completed successfully on FW. If error returned we are getting confusing messages in dmesg. In addition, currently returned value -1 is confusing with -EPERM. New implementation actually fix original commit and return meaningful codes for commands delivery status and print message in case of failure. Fixes: ("mlx5: Add driver for Mellanox Connect-IB adapters") Signed-off-by:

Valentine Fatiev <valentinef@mellanox.com> Signed-off-by:

Saeed Mahameed <saeedm@mellanox.com>

drivers/net/ethernet/mellanox/mlx5/core/cmd.c

+21 −1

Original line number	Diff line number	Diff line
		@@ -1604,7 +1604,27 @@ void mlx5_cmd_flush(struct mlx5_core_dev *dev)

		static int status_to_err(u8 status)
		{
		return status ? -1 : 0; /* TBD more meaningful codes */
		switch (status) {
		case MLX5_CMD_DELIVERY_STAT_OK:
		case MLX5_DRIVER_STATUS_ABORTED:
		return 0;
		case MLX5_CMD_DELIVERY_STAT_SIGNAT_ERR:
		case MLX5_CMD_DELIVERY_STAT_TOK_ERR:
		return -EBADR;
		case MLX5_CMD_DELIVERY_STAT_BAD_BLK_NUM_ERR:
		case MLX5_CMD_DELIVERY_STAT_OUT_PTR_ALIGN_ERR:
		case MLX5_CMD_DELIVERY_STAT_IN_PTR_ALIGN_ERR:
		return -EFAULT; /* Bad address */
		case MLX5_CMD_DELIVERY_STAT_IN_LENGTH_ERR:
		case MLX5_CMD_DELIVERY_STAT_OUT_LENGTH_ERR:
		case MLX5_CMD_DELIVERY_STAT_CMD_DESCR_ERR:
		case MLX5_CMD_DELIVERY_STAT_RES_FLD_NOT_CLR_ERR:
		return -ENOMSG;
		case MLX5_CMD_DELIVERY_STAT_FW_ERR:
		return -EIO;
		default:
		return -EINVAL;
		}
		}

		static struct mlx5_cmd_msg alloc_msg(struct mlx5_core_dev dev, int in_size,

Admin message