exofs: stop using s_dirt (66153f6e) · Commits · 戴 / test

Exofs has the '->write_super()' handler and makes some use of the '->s_dirt' superblock flag, but it really needs neither of them because it never sets 's_dirt' to one which means the VFS never calls its '->write_super()' handler. Thus, remove both. Note, I am trying to remove both 's_dirt' and 'write_super()' from VFS altogether once all users are gone. Signed-off-by:

Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Signed-off-by:

Boaz Harrosh <bharrosh@panasas.com>

fs/exofs/super.c

+0 −11

Original line number	Diff line number	Diff line
		@@ -400,8 +400,6 @@ static int exofs_sync_fs(struct super_block *sb, int wait)
		ret = ore_write(ios);
		if (unlikely(ret))
		EXOFS_ERR("%s: ore_write failed.\n", __func__);
		else
		sb->s_dirt = 0;


		unlock_super(sb);
		@@ -412,14 +410,6 @@ out:
		return ret;
		}

		static void exofs_write_super(struct super_block *sb)
		{
		if (!(sb->s_flags & MS_RDONLY))
		exofs_sync_fs(sb, 1);
		else
		sb->s_dirt = 0;
		}

		static void _exofs_print_device(const char msg, const char dev_path,
		struct osd_dev *od, u64 pid)
		{
		@@ -952,7 +942,6 @@ static const struct super_operations exofs_sops = {
		.write_inode = exofs_write_inode,
		.evict_inode = exofs_evict_inode,
		.put_super = exofs_put_super,
		.write_super = exofs_write_super,
		.sync_fs = exofs_sync_fs,
		.statfs = exofs_statfs,
		};

Admin message