Commit 6610a0bc authored Oct 16, 2007 by Andrew Morton Committed by Linus Torvalds Oct 17, 2007

writeback: fix time-ordering of the per-superblock dirty-inode lists



When writeback has finished writing back an inode it looks to see if that
inode is still dirty.  If it is, that means that a process redirtied the inode
while its writeback was in progress.

What we need to do here is to refile the redirtied inode onto the s_dirty
list.

But we're doing that wrongly: it could be that this inode was redirtied
_before_ the last inode on s_dirty.  We're blindly appending this inode to the
list, after an inode which might be less-recently-dirtied, thus violating the
list's ordering.

So we must either insertion-sort this inode into the correct place, or we must
update this inode's dirtied_when field when appending it to the reverse-sorted
s_dirty list, to preserve the reverse-time-ordering.

This patch does the latter: if this inode was dirtied less recently than the
tail inode then copy the tail inode's timestamp into this inode.

This means that in rare circumstances, some inodes will be writen back later
than they should have been.  But the time slip will be small.

Cc: Mike Waychison <mikew@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 2b0172e1

fs/fs-writeback.c

+25 −1

Original line number	Diff line number	Diff line
		@@ -140,6 +140,30 @@ static int write_inode(struct inode *inode, int sync)
		return 0;
		}

		/*
		* Redirty an inode: set its when-it-was dirtied timestamp and move it to the
		* furthest end of its superblock's dirty-inode list.
		*
		* Before stamping the inode's ->dirtied_when, we check to see whether it is
		* already the most-recently-dirtied inode on the s_dirty list. If that is
		* the case then the inode must have been redirtied while it was being written
		* out and we don't reset its dirtied_when.
		*/
		static void redirty_tail(struct inode *inode)
		{
		struct super_block *sb = inode->i_sb;

		if (!list_empty(&sb->s_dirty)) {
		struct inode *tail_inode;

		tail_inode = list_entry(sb->s_dirty.next, struct inode, i_list);
		if (!time_after_eq(inode->dirtied_when,
		tail_inode->dirtied_when))
		inode->dirtied_when = jiffies;
		}
		list_move(&inode->i_list, &sb->s_dirty);
		}

		/*
		* Write a single inode's dirty pages and inode data out to disk.
		* If `wait' is set, wait on the writeout.
		@@ -219,7 +243,7 @@ __sync_single_inode(struct inode inode, struct writeback_control wbc)
		* Someone redirtied the inode while were writing back
		* the pages.
		*/
		list_move(&inode->i_list, &sb->s_dirty);
		redirty_tail(inode);
		} else if (atomic_read(&inode->i_count)) {
		/*
		* The inode is clean, inuse

Admin message