Commit 65caafd0 authored by Olga Kornievskaia's avatar Olga Kornievskaia Committed by Anna Schumaker
Browse files

SUNRPC reverting d03727b2 ("NFSv4 fix CLOSE not waiting for direct IO compeletion") 



Reverting commit d03727b2 "NFSv4 fix CLOSE not waiting for
direct IO compeletion". This patch made it so that fput() by calling
inode_dio_done() in nfs_file_release() would wait uninterruptably
for any outstanding directIO to the file (but that wait on IO should
be killable).

The problem the patch was also trying to address was REMOVE returning
ERR_ACCESS because the file is still opened, is supposed to be resolved
by server returning ERR_FILE_OPEN and not ERR_ACCESS.

Signed-off-by: default avatarOlga Kornievskaia <kolga@netapp.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 91228844

fs/nfs/direct.c

+4 −9
Original line number Diff line number Diff line
@@ -267,6 +267,8 @@ static void nfs_direct_complete(struct nfs_direct_req *dreq) 
{

	struct inode *inode = dreq->inode;



	inode_dio_end(inode);



	if (dreq->iocb) {

		long res = (long) dreq->error;

		if (dreq->count != 0) {
@@ -278,10 +280,7 @@ static void nfs_direct_complete(struct nfs_direct_req *dreq) 


	complete(&dreq->completion);



	igrab(inode);

	nfs_direct_req_release(dreq);

	inode_dio_end(inode);

	iput(inode);

}



static void nfs_direct_read_completion(struct nfs_pgio_header *hdr)
@@ -411,10 +410,8 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq, 
	 * generic layer handle the completion.

	 */

	if (requested_bytes == 0) {

		igrab(inode);

		nfs_direct_req_release(dreq);

		inode_dio_end(inode);

		iput(inode);

		nfs_direct_req_release(dreq);

		return result < 0 ? result : -EIO;

	}
@@ -867,10 +864,8 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq, 
	 * generic layer handle the completion.

	 */

	if (requested_bytes == 0) {

		igrab(inode);

		nfs_direct_req_release(dreq);

		inode_dio_end(inode);

		iput(inode);

		nfs_direct_req_release(dreq);

		return result < 0 ? result : -EIO;

	}

fs/nfs/file.c

+0 −1
Original line number Diff line number Diff line
@@ -83,7 +83,6 @@ nfs_file_release(struct inode *inode, struct file *filp) 
	dprintk("NFS: release(%pD2)\n", filp);



	nfs_inc_stats(inode, NFSIOS_VFSRELEASE);

	inode_dio_wait(inode);

	nfs_file_clear_open_context(filp);

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE