sched/topology: Verify SD_* flags setup when sched_debug is on (65c5e253) · Commits · 戴 / test

Now that we have some description of what we expect the flags layout to be, we can use that to assert at runtime that the actual layout is sane. Signed-off-by:

Valentin Schneider <valentin.schneider@arm.com> Signed-off-by:

Ingo Molnar <mingo@kernel.org> Reviewed-by:

Dietmar Eggemann <dietmar.eggemann@arm.com> Acked-by:

Peter Zijlstra <a.p.zijlstra@chello.nl> Link: https://lore.kernel.org/r/20200817113003.20802-6-valentin.schneider@arm.com

kernel/sched/topology.c

+17 −0

Original line number	Diff line number	Diff line
		@@ -29,6 +29,8 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,
		struct cpumask *groupmask)
		{
		struct sched_group *group = sd->groups;
		unsigned long flags = sd->flags;
		unsigned int idx;

		cpumask_clear(groupmask);

		@@ -43,6 +45,21 @@ static int sched_domain_debug_one(struct sched_domain *sd, int cpu, int level,
		printk(KERN_ERR "ERROR: domain->groups does not contain CPU%d\n", cpu);
		}

		for_each_set_bit(idx, &flags, __SD_FLAG_CNT) {
		unsigned int flag = BIT(idx);
		unsigned int meta_flags = sd_flag_debug[idx].meta_flags;

		if ((meta_flags & SDF_SHARED_CHILD) && sd->child &&
		!(sd->child->flags & flag))
		printk(KERN_ERR "ERROR: flag %s set here but not in child\n",
		sd_flag_debug[idx].name);

		if ((meta_flags & SDF_SHARED_PARENT) && sd->parent &&
		!(sd->parent->flags & flag))
		printk(KERN_ERR "ERROR: flag %s set here but not in parent\n",
		sd_flag_debug[idx].name);
		}

		printk(KERN_DEBUG "%*s groups:", level + 1, "");
		do {
		if (!group) {

Admin message