Commit 65c3b205 authored Apr 30, 2015 by Dan Carpenter Committed by Steve French May 20, 2015

CIFS: remove an unneeded NULL check



Smatch complains because we dereference "ses->server" without checking
some lines earlier inside the call to get_next_mid(ses->server).

	fs/cifs/cifssmb.c:4921 CIFSGetDFSRefer()
	warn: variable dereferenced before check 'ses->server' (see line 4899)

There is only one caller for this function get_dfs_path() and it always
passes a non-null "ses->server" pointer so this NULL check can be
removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <smfrench@gmail.com>

parent 1dc92c45

fs/cifs/cifssmb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4918,7 +4918,7 @@ getDFSRetry:
		strncpy(pSMB->RequestFileName, search_name, name_len);
		}

		if (ses->server && ses->server->sign)
		if (ses->server->sign)
		pSMB->hdr.Flags2 \|= SMBFLG2_SECURITY_SIGNATURE;

		pSMB->hdr.Uid = ses->Suid;

Admin message