Commit 65ba6b54 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

nvme: make nvme_error_status private 



Currently it's used by the lighnvm passthrough ioctl, but we'd like to make
it private in preparation of block layer specific error code.  Lighnvm already
returns the real NVMe status anyway, so I think we can just limit it to
returning -EIO for any status set.

This will need a careful audit from the lightnvm folks, though.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 27fa9bc5

drivers/nvme/host/core.c

+1 −2
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ static DEFINE_SPINLOCK(dev_list_lock); 


static struct class *nvme_class;



int nvme_error_status(struct request *req)

static int nvme_error_status(struct request *req)

{

	switch (nvme_req(req)->status & 0x7ff) {

	case NVME_SC_SUCCESS:
@@ -77,7 +77,6 @@ int nvme_error_status(struct request *req) 
		return -EIO;

	}

}

EXPORT_SYMBOL_GPL(nvme_error_status);



static inline bool nvme_req_needs_retry(struct request *req)

{

drivers/nvme/host/lightnvm.c

+3 −3
Original line number Diff line number Diff line
@@ -595,7 +595,7 @@ static int nvme_nvm_submit_user_cmd(struct request_queue *q, 
	__le64 *metadata = NULL;

	dma_addr_t metadata_dma;

	DECLARE_COMPLETION_ONSTACK(wait);

	int ret;

	int ret = 0;



	rq = nvme_alloc_request(q, (struct nvme_command *)vcmd, 0,

			NVME_QID_ANY);
@@ -667,8 +667,8 @@ submit: 


	if (nvme_req(rq)->flags & NVME_REQ_CANCELLED)

		ret = -EINTR;

	else

		ret = nvme_error_status(rq);

	else if (nvme_req(rq)->status & 0x7ff)

		ret = -EIO;

	if (result)

		*result = nvme_req(rq)->status & 0x7ff;

	if (status)

drivers/nvme/host/nvme.h

+0 −1
Original line number Diff line number Diff line
@@ -254,7 +254,6 @@ static inline void nvme_end_request(struct request *req, __le16 status, 
	blk_mq_complete_request(req, 0);

}



int nvme_error_status(struct request *req);

void nvme_complete_rq(struct request *req);

void nvme_cancel_request(struct request *req, void *data, bool reserved);

bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl,

CRA Git | Maintained and supported by SUSTech CRA and CCSE