Unverified Commit 65acd82c authored Sep 01, 2020 by Krzysztof Kozlowski Committed by Mark Brown Sep 08, 2020

spi: bcm2835: Simplify with dev_err_probe()



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20200901152713.18629-4-krzk@kernel.org


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 96189475

drivers/spi/spi-bcm2835.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -1319,11 +1319,8 @@ static int bcm2835_spi_probe(struct platform_device *pdev)

		bs->clk = devm_clk_get(&pdev->dev, NULL);
		if (IS_ERR(bs->clk)) {
		err = PTR_ERR(bs->clk);
		if (err == -EPROBE_DEFER)
		dev_dbg(&pdev->dev, "could not get clk: %d\n", err);
		else
		dev_err(&pdev->dev, "could not get clk: %d\n", err);
		err = dev_err_probe(&pdev->dev, PTR_ERR(bs->clk),
		"could not get clk\n");
		goto out_controller_put;
		}

Admin message