Commit 659c6009 authored Oct 27, 2010 by Eric Sandeen Committed by Theodore Ts'o Oct 27, 2010

ext4: stop looping in ext4_num_dirty_pages when max_pages reached



Today we simply break out of the inner loop when we have accumulated
max_pages; this keeps scanning forwad and doing pagevec_lookup_tag()
in the while (!done) loop, this does potentially a lot of work
with no net effect.

When we have accumulated max_pages, just clean up and return.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

parent fb1813f4

fs/ext4/inode.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1207,9 +1207,11 @@ static pgoff_t ext4_num_dirty_pages(struct inode *inode, pgoff_t idx,
		break;
		idx++;
		num++;
		if (num >= max_pages)
		if (num >= max_pages) {
		done = 1;
		break;
		}
		}
		pagevec_release(&pvec);
		}
		return num;

Admin message