Commit 65891fea authored by Or Gerlitz's avatar Or Gerlitz Committed by David S. Miller
Browse files

net: Disallow providing non zero VLAN ID for NIC drivers FDB add flow 



The current implementations all use dev_uc_add_excl() and such whose API
doesn't support vlans, so we can't make it with NICs HW for now.

Fixes: f6f6424b ('net: make vid as a parameter for ndo_fdb_add/ndo_fdb_del')
Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: default avatarJiri Pirko <jiri@resnulli.us>
Acked-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c3f2511f

drivers/net/ethernet/intel/i40e/i40e_main.c

+5 −0
Original line number Diff line number Diff line
@@ -7549,6 +7549,11 @@ static int i40e_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[], 
	if (!(pf->flags & I40E_FLAG_SRIOV_ENABLED))

		return -EOPNOTSUPP;



	if (vid) {

		pr_info("%s: vlans aren't supported yet for dev_uc|mc_add()\n", dev->name);

		return -EINVAL;

	}



	/* Hardware does not support aging addresses so if a

	 * ndm_state is given only allow permanent addresses

	 */

net/core/rtnetlink.c

+5 −0
Original line number Diff line number Diff line
@@ -2368,6 +2368,11 @@ int ndo_dflt_fdb_add(struct ndmsg *ndm, 
		return err;

	}



	if (vid) {

		pr_info("%s: vlans aren't supported yet for dev_uc|mc_add()\n", dev->name);

		return err;

	}



	if (is_unicast_ether_addr(addr) || is_link_local_ether_addr(addr))

		err = dev_uc_add_excl(dev, addr);

	else if (is_multicast_ether_addr(addr))

CRA Git | Maintained and supported by SUSTech CRA and CCSE