Commit 657bdfb7 authored Jan 17, 2017 by Eric Sandeen Committed by Darrick J. Wong Jan 17, 2017

xfs: don't wrap ID in xfs_dq_get_next_id



The GETNEXTQOTA ioctl takes whatever ID is sent in,
and looks for the next active quota for an user
equal or higher to that ID.

But if we are at the maximum ID and then ask for the "next"
one, we may wrap back to zero.  In this case, userspace
may loop forever, because it will start querying again
at zero.

We'll fix this in userspace as well, but for the kernel,
return -ENOENT if we ask for the next quota ID
past UINT_MAX so the caller knows to stop.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent a324cbf1

fs/xfs/xfs_dquot.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -710,6 +710,10 @@ xfs_dq_get_next_id(
		/* Simple advance */
		next_id = *id + 1;

		/* If we'd wrap past the max ID, stop */
		if (next_id < *id)
		return -ENOENT;

		/* If new ID is within the current chunk, advancing it sufficed */
		if (next_id % mp->m_quotainfo->qi_dqperchunk) {
		*id = next_id;

Admin message