Commit 6577ae51 authored by Roland Dreier's avatar Roland Dreier
Browse files

[PATCH] IB/mthca: Don't try to set srq->last for userspace SRQs 



Userspace SRQs don't have a buffer allocated for them in the kernel, so
it doesn't make sense to set srq->last during initialization.  In fact,
this can crash trying to follow a nonexistent buffer pointer.

Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
parent 3853194c

drivers/infiniband/hw/mthca/mthca_srq.c

+2 −1
Original line number Diff line number Diff line
@@ -172,6 +172,8 @@ static int mthca_alloc_srq_buf(struct mthca_dev *dev, struct mthca_pd *pd, 
			scatter->lkey = cpu_to_be32(MTHCA_INVAL_LKEY);

	}



	srq->last = get_wqe(srq, srq->max - 1);



	return 0;

}
@@ -263,7 +265,6 @@ int mthca_alloc_srq(struct mthca_dev *dev, struct mthca_pd *pd, 


	srq->first_free = 0;

	srq->last_free  = srq->max - 1;

	srq->last	= get_wqe(srq, srq->max - 1);



	return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE