Commit 655babbd authored by Doug Anderson's avatar Doug Anderson Committed by Ulf Hansson
Browse files

mmc: dw_mmc: Make sure we only adjust the clock when power is on 



It appears that we can confuse things if we try to turn on the MMC
clock when the power is off.  Adjust is so that we turn the clock on
(using dw_mci_setup_bus) after power is all the way on and we turn the
clock off before the power goes off.

Signed-off-by: default avatarDoug Anderson <dianders@chromium.org>
Tested-by: default avatarJavier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: default avatarJaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent bdb9a90b

drivers/mmc/host/dw_mmc.c

+10 −6
Original line number Diff line number Diff line
@@ -1102,12 +1102,6 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) 
	if (drv_data && drv_data->set_ios)

		drv_data->set_ios(slot->host, ios);



	/* Slot specific timing and width adjustment */

	dw_mci_setup_bus(slot, false);



	if (slot->host->state == STATE_WAITING_CMD11_DONE && ios->clock != 0)

		slot->host->state = STATE_IDLE;



	switch (ios->power_mode) {

	case MMC_POWER_UP:

		if (!IS_ERR(mmc->supply.vmmc)) {
@@ -1134,8 +1128,15 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) 
			else

				slot->host->vqmmc_enabled = true;

		}



		/* Adjust clock / bus width after power is up */

		dw_mci_setup_bus(slot, false);



		break;

	case MMC_POWER_OFF:

		/* Turn clock off before power goes down */

		dw_mci_setup_bus(slot, false);



		if (!IS_ERR(mmc->supply.vmmc))

			mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, 0);
@@ -1151,6 +1152,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) 
	default:

		break;

	}



	if (slot->host->state == STATE_WAITING_CMD11_DONE && ios->clock != 0)

		slot->host->state = STATE_IDLE;

}



static int dw_mci_card_busy(struct mmc_host *mmc)

CRA Git | Maintained and supported by SUSTech CRA and CCSE