Commit 6553e561 authored Jul 21, 2020 by Parav Pandit Committed by David S. Miller Jul 21, 2020

devlink: Do not hold devlink mutex when initializing devlink fields



There is no need to hold a device global lock when initializing
devlink device fields of a devlink instance which is not yet part of the
devices list.

Signed-off-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3fc364c0

net/core/devlink.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -7421,9 +7421,9 @@ EXPORT_SYMBOL_GPL(devlink_alloc);
		*/
		int devlink_register(struct devlink devlink, struct device dev)
		{
		mutex_lock(&devlink_mutex);
		devlink->dev = dev;
		devlink->registered = true;
		mutex_lock(&devlink_mutex);
		list_add_tail(&devlink->list, &devlink_list);
		devlink_notify(devlink, DEVLINK_CMD_NEW);
		mutex_unlock(&devlink_mutex);

Admin message