Commit 654a3667 authored Mar 29, 2020 by Chaitanya Kulkarni Committed by Jens Axboe Mar 29, 2020

block: return NULL in blk_alloc_queue() on error



This patch fixes follwoing warning:

block/blk-core.c: In function ‘blk_alloc_queue’:
block/blk-core.c:558:10: warning: returning ‘int’ from a function with return type ‘struct request_queue *’ makes pointer from integer without a cast [-Wint-conversion]
   return -EINVAL;

Fixes: 3d745ea5 ("block: simplify queue allocation")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 130879f1

block/blk-core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -555,7 +555,7 @@ struct request_queue *blk_alloc_queue(make_request_fn make_request, int node_id)
		struct request_queue *q;

		if (WARN_ON_ONCE(!make_request))
		return -EINVAL;
		return NULL;

		q = __blk_alloc_queue(node_id);
		if (!q)

Admin message