Commit 6544abc5 authored Jul 15, 2020 by Walter Lozano Committed by Viresh Kumar Jul 16, 2020

opp: Increase parsed_static_opps in _of_add_opp_table_v1()



Currently, when using _of_add_opp_table_v2 parsed_static_opps is
increased and this value is used in _opp_remove_all_static() to
check if there are static opp entries that need to be freed.
Unfortunately this does not happen when using _of_add_opp_table_v1(),
which leads to warnings.

This patch increases parsed_static_opps in _of_add_opp_table_v1() in a
similar way as in _of_add_opp_table_v2().

Fixes: 03758d60 ("opp: Replace list_kref with a local counter")
Cc: v5.6+ <stable@vger.kernel.org> # v5.6+
Signed-off-by: Walter Lozano <walter.lozano@collabora.com>
[ Viresh: Do the operation with lock held and set the value to 1 instead
	  of incrementing it ]
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

parent b3a9e3b9

drivers/opp/of.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -902,6 +902,10 @@ static int _of_add_opp_table_v1(struct device dev, struct opp_table opp_table)
		return -EINVAL;
		}

		mutex_lock(&opp_table->lock);
		opp_table->parsed_static_opps = 1;
		mutex_unlock(&opp_table->lock);

		val = prop->value;
		while (nr) {
		unsigned long freq = be32_to_cpup(val++) * 1000;

Admin message